Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#97] drain.sh cannot detect queue type on dual routing type addresses #98

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[#97] drain.sh cannot detect queue type on dual routing type addresses #98

wants to merge 1 commit into from

Conversation

gaohoward
Copy link
Collaborator

Thanks for submitting your Pull Request!

Please make sure your PR meets the following requirements:

  • Pull Request title is properly formatted: [CLOUD-XYA] Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
  • Attached commits represent units of work and are properly formatted
  • You have read and agreed to the Developer Certificate of Origin (DCO) (see CONTRIBUTING.md)
  • Every commit contains Signed-off-by: Your Name <[email protected]> - use git commit -s

@gaohoward gaohoward linked an issue Dec 12, 2023 that may be closed by this pull request
drain.sh cannot detect queue type on dual routing type addresses #97
Open
brusdev
brusdev approved these changes Jan 15, 2024
View reviewed changes
Copy link
Contributor

@brusdev brusdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix LGTM but I see a lot of new debug logs without the possibility to disable them.

@brusdev
Copy link
Contributor

brusdev commented Sep 6, 2024

@howardgao are you still working on this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brusdev brusdev brusdev approved these changes

@gtully gtully Awaiting requested review from gtully

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drain.sh cannot detect queue type on dual routing type addresses
3 participants
@gaohoward @brusdev @howardgao