Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to FITS #476

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Remove references to FITS #476

merged 2 commits into from
Sep 12, 2024

Conversation

replaceafill
Copy link
Member

@replaceafill replaceafill changed the base branch from 1.16 to 1.17 September 6, 2024 15:28
@Dhwaniartefact
Copy link
Contributor

LGTM!

Just a thought came, we can remove FITS information from Locale directory in future.

@replaceafill
Copy link
Member Author

Just a thought came, we can remove FITS information from Locale directory in future.

Good point! I think this will be solved once we re-implement a translation workflow for the app and docs. The gettext workflow should be able to detect those strings are not present in the source pages anymore and update the locale files accordingly.

Copy link
Contributor

@sromkey sromkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few suggestions!

@@ -178,9 +178,9 @@ The user may choose to continue processing the SIP despite any normalization
errors.

The user may choose to redo normalization, as well. For instance, if
the user chose to normalize based on FITS-JHOVE results and experienced
the user chose to normalize based on one tool results and experienced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to "one tool's"

failures, the user may wish to redo normalization and choose to normalize
based on FITS-DROID results instead.
based on another tool results instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"another tool's"

to handle vector images.
preservation actions. These include digital preservation specific tools as well
as tools for handling different file formats like `Inkscape`_, which is a design
program used to handle vector images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to suggest a reword of these three lines so that we avoid mentioning any tool specifically:
"preservation actions. These include digital preservation specific tools (such as those to carry out file format identification and characterization) as well as generalist tools used for actions such as normalization."

Copy link
Contributor

@sromkey sromkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@replaceafill replaceafill merged commit a635417 into 1.17 Sep 12, 2024
4 checks passed
@replaceafill replaceafill deleted the dev/issue-703-remove-fits branch September 12, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants