Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tracing in the a3m gRPC client #905

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Mar 28, 2024

Enable OpenTelemetry tracing in the gRPC client and create it from main following recommended practices. I've also added a small test for the a3m activity, but it's improvable.

After checking out the traces in Grafana I realized that we were sending hundreds of Read requests to a3m so I've also introduced a small wait between reads to reduce the frequency.

image

@sevein sevein requested a review from djjuhasz March 28, 2024 20:09
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 43.47826% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 48.17%. Comparing base (9f4a60a) to head (32ae4fb).
Report is 1 commits behind head on main.

Files Patch % Lines
cmd/enduro-a3m-worker/main.go 0.00% 6 Missing ⚠️
internal/a3m/client.go 0.00% 6 Missing ⚠️
internal/a3m/a3m.go 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
+ Coverage   46.83%   48.17%   +1.33%     
==========================================
  Files         103      103              
  Lines        5549     5555       +6     
==========================================
+ Hits         2599     2676      +77     
+ Misses       2713     2636      -77     
- Partials      237      243       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, but it's not a blocker. 👍

@sevein sevein force-pushed the dev/a3m-grpc-client-otel branch from 0816fa2 to f317ee7 Compare March 28, 2024 21:18
@sevein sevein force-pushed the dev/a3m-grpc-client-otel branch from f317ee7 to 32ae4fb Compare March 28, 2024 21:20
@sevein sevein merged commit 6b6cdf8 into main Mar 28, 2024
12 of 13 checks passed
@sevein sevein deleted the dev/a3m-grpc-client-otel branch March 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants