Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upload-sample-transfer helper #904

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add upload-sample-transfer helper #904

merged 1 commit into from
Mar 28, 2024

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Mar 28, 2024

Would this be useful? I see myself all the time running that command locally to test new transfers. I know that the Tilt button exists but often I'm closer to the terminal than to the Tilt dashboard.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.87%. Comparing base (f075824) to head (f8d5bb3).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
- Coverage   47.11%   46.87%   -0.24%     
==========================================
  Files          96      103       +7     
  Lines        5383     5549     +166     
==========================================
+ Hits         2536     2601      +65     
- Misses       2611     2712     +101     
  Partials      236      236              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz self-requested a review March 28, 2024 19:18
Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sevein sevein merged commit 133a148 into main Mar 28, 2024
13 checks passed
@sevein sevein deleted the dev/upload-helper branch March 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants