Add unit tests for package_.CreatePreservationTask()
#901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #901 +/- ##
==========================================
+ Coverage 47.11% 48.00% +0.88%
==========================================
Files 96 101 +5
Lines 5383 5402 +19
==========================================
+ Hits 2536 2593 +57
+ Misses 2611 2571 -40
- Partials 236 238 +2 ☔ View full report in Codecov by Sentry. |
djjuhasz
force-pushed
the
dev/issue-900-create-pres-task-tests
branch
from
8e9a086 to
4420aa2
Compare
djjuhasz
force-pushed
the
dev/issue-900-create-pres-task-tests
branch
from
4420aa2 to
780d2d1
Compare
- Make the ent preservation_action `StartedAt` and `CompletedAt` columns nullable - Make the ent preservation_task `StartedAt` and `CompletedAt` columns nullable
Split ent client package methods into a separate `package` file.
- Move `package_.PreservationTask` struct to `datatypes.PreservationTask` to avoid circular imports - Move PreservationTask enums to the `enums` package to avoid circular imports
- Move PreservationAction struct to `datatypes` package - Move PreservationAction enums to `enums` package
I originally intended the eventManager wrapper as layer to compose the event and persistence services. With the switch to including the persistence service in the package service, it is less work to compose the event and persistence services in the package service and doesn't require a separate service.
- Add `CreatePreservationTask()` to the ent client - Add `CreatePreservationTask()` to the persistence service - Regenerate the persistence service mocks - Add a `convertPreservationTask()` function to convert a `db.PreservationTask` to a `datatype.PreservationTask` struct
Fixes #900 - Use `persistence.CreatePreservationTask()` instead of a SQL query in the package service - Add a `preservationTaskToGoa()` function to convert `datatypes.PreservationTask` to a Goa `EnduroPackagePreservationTask` struct [skip codecov]
djjuhasz
force-pushed
the
dev/issue-900-create-pres-task-tests
branch
from
780d2d1 to
9ac3b10
Compare
[skip codecov]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #900
persistence.CreatePreservationTask()method, and add an implementation to the ent clientpersistence.CreatePreservationTask()frompackage_.CreatePreservationTask()instead of using direct SQL queriespersistence.eventManagerservice wrapper