Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce coverage thresholds #894

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Mar 15, 2024

A tentative solution for #892 that updates the codecov config to allow a certain number of lines to transition from covered to uncovered without reporting a negative patch coverage result.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.31%. Comparing base (2f9b4c1) to head (4f51a31).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   47.38%   47.31%   -0.08%     
==========================================
  Files          95       95              
  Lines        5172     5172              
==========================================
- Hits         2451     2447       -4     
- Misses       2491     2493       +2     
- Partials      230      232       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevein sevein force-pushed the dev/issue-892-introduce-codecov-thresholds branch from a9c247f to 4f51a31 Compare March 15, 2024 12:17
Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@djjuhasz djjuhasz merged commit 7e99584 into main Mar 15, 2024
13 checks passed
@djjuhasz djjuhasz deleted the dev/issue-892-introduce-codecov-thresholds branch March 15, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants