Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go in devbox #890

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update go in devbox #890

merged 3 commits into from
Apr 3, 2024

Conversation

Diogenesoftoronto
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.13%. Comparing base (2f9b4c1) to head (07fee51).
Report is 42 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #890      +/-   ##
==========================================
+ Coverage   47.38%   48.13%   +0.74%     
==========================================
  Files          95      103       +8     
  Lines        5172     5555     +383     
==========================================
+ Hits         2451     2674     +223     
- Misses       2491     2637     +146     
- Partials      230      244      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -9,7 +9,8 @@
"docker@latest",
"python3@latest",
"markdownlint-cli@latest",
"python311Packages.pip-tools@latest"
"python311Packages.pip-tools@latest",
"go_1_22@latest"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to keep go_1_21?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you noticed that it's installing 1.22.0 instead of 1.22.1? Can that be changed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh absolutely. Seems that stuck around during some work I was doing in the repo.

Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, I still see "1.22.0".

@Diogenesoftoronto
Copy link
Contributor Author

Weird, I still see "1.22.0".

Oh my gosh, sorry for the long update, some of my work got lost. I am learning to use gitbutler and some of my changes were not recovered because of the way that it works.

@Diogenesoftoronto Diogenesoftoronto merged commit 1c92e2b into main Apr 3, 2024
13 checks passed
@Diogenesoftoronto Diogenesoftoronto deleted the dev/update-devbox branch April 3, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants