Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore unparam linter #887

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Restore unparam linter #887

merged 2 commits into from
Mar 14, 2024

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Mar 13, 2024

Restore the unparam linter in golangci-lint since it's working again with recent releases of Go and golang.org/x/tools.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.22%. Comparing base (620f36f) to head (37bcb55).
Report is 7 commits behind head on main.

❗ Current head 37bcb55 differs from pull request most recent head 559753d. Consider uploading reports for the commit 559753d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #887      +/-   ##
==========================================
- Coverage   47.27%   47.22%   -0.05%     
==========================================
  Files          94       94              
  Lines        5096     5135      +39     
==========================================
+ Hits         2409     2425      +16     
- Misses       2466     2488      +22     
- Partials      221      222       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevein sevein force-pushed the dev/restore-unparam-linter branch from 37bcb55 to 559753d Compare March 13, 2024 12:03
Copy link
Collaborator

@djjuhasz djjuhasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sevein sevein merged commit 9e01d3f into main Mar 14, 2024
11 checks passed
@sevein sevein deleted the dev/restore-unparam-linter branch March 14, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants