Add result struct to activity function signature

[Diogenesoftoronto]

closes #800

[codecov]

Codecov Report

Attention: Patch coverage is 12.69841% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 47.12%. Comparing base (620f36f) to head (8318770).
Report is 7 commits behind head on main.

❗ Current head 8318770 differs from pull request most recent head cf21f7d. Consider uploading reports for the commit cf21f7d to get more accurate results

Files	Patch %	Lines
internal/workflow/local_activities.go	0.00%	18 Missing ⚠️
internal/storage/activities/copy.go	0.00%	9 Missing ⚠️
internal/workflow/activities/upload.go	22.22%	7 Missing ⚠️
internal/workflow/activities/storage.go	0.00%	6 Missing ⚠️
internal/workflow/activities/bundle.go	0.00%	5 Missing ⚠️
internal/workflow/activities/cleanup.go	0.00%	4 Missing ⚠️
internal/workflow/activities/delete_original.go	0.00%	2 Missing ⚠️
internal/workflow/activities/dispose_original.go	0.00%	2 Missing ⚠️
internal/workflow/activities/download.go	50.00%	1 Missing ⚠️
internal/workflow/activities/zip.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #881      +/-   ##
==========================================
- Coverage   47.27%   47.12%   -0.15%     
==========================================
  Files          94       94              
  Lines        5096     5135      +39     
==========================================
+ Hits         2409     2420      +11     
- Misses       2466     2492      +26     
- Partials      221      223       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[djjuhasz]

LGTM! 👍

[sevein]

Your approach is nearly correct; however, I've noticed an oversight. You're returning a nil pointer instead of a pointer to the result struct when there's no error. I'll highlight a few examples, although I've observed this issue in several places.

[Diogenesoftoronto]

I made the recommend changes in the new commits. I also added some comments with my thoughts as a whole.

[sevein]

Can you rebase? 🙏