Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Github actions/setup-go from v4 to v5 #876

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

djjuhasz
Copy link
Collaborator

@djjuhasz djjuhasz commented Mar 7, 2024

Fixes a Github actions error:

Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/setup-go@v4.

Fixes a Github actions error:

```
Node.js 16 actions are deprecated. Please update the following actions
to use Node.js 20: actions/setup-go@v4.
```
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.23%. Comparing base (aff8ee3) to head (4083c0b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   47.27%   47.23%   -0.04%     
==========================================
  Files          94       94              
  Lines        5087     5087              
==========================================
- Hits         2405     2403       -2     
- Misses       2461     2462       +1     
- Partials      221      222       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz requested review from sevein and jraddaoui March 7, 2024 17:09
Copy link
Collaborator

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What the heck is Codecov complaining about? LGTM

@djjuhasz
Copy link
Collaborator Author

djjuhasz commented Mar 7, 2024

What the heck is Codecov complaining about? LGTM

@jraddaoui Codecov's algorithm for diffing changes seems overly strict to me, and I don't know why it thinks code coverage goes down with this commit. 😕

@djjuhasz djjuhasz merged commit 509d478 into main Mar 7, 2024
12 of 13 checks passed
@djjuhasz djjuhasz deleted the dev/bump-actions-setup-go-v5 branch March 7, 2024 17:24
@jraddaoui
Copy link
Collaborator

And it should not look at YAML files, specially those.

@djjuhasz
Copy link
Collaborator Author

djjuhasz commented Mar 7, 2024

@jraddaoui good point, I'll look into adding the .github directory to the Codecov ignored paths.

@sevein
Copy link
Contributor

sevein commented Mar 7, 2024

I think that we have a test or two where the code tested isn't consistently working the same way in all runs. Codecov calls it "indirect changes" and it lists a bunch of potential reasons here: https://docs.codecov.com/docs/unexpected-coverage-changes#reasons-for-indirect-changes. Should be possible to fix.

Update: see #879.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants