Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint from 1.56.0 to 1.56.1 #862

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Feb 9, 2024

In 1.56.1 govet:loopclosure comes disabled by default for go1.22 so we don't have to manually disable it in the golangci-lint yaml config.

I've also updated the action so it uses make lint and basic caching.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c1b843) 45.33% compared to head (056c87b) 45.41%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #862      +/-   ##
==========================================
+ Coverage   45.33%   45.41%   +0.07%     
==========================================
  Files          93       93              
  Lines        5036     5036              
==========================================
+ Hits         2283     2287       +4     
+ Misses       2550     2548       -2     
+ Partials      203      201       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevein sevein force-pushed the dev/update-golangci-lint branch 4 times, most recently from 742286f to 5a1ec5c Compare February 9, 2024 11:40
@sevein sevein force-pushed the dev/update-golangci-lint branch from 5a1ec5c to 056c87b Compare February 9, 2024 11:46
@sevein sevein merged commit b0e5362 into main Feb 9, 2024
13 checks passed
@sevein sevein deleted the dev/update-golangci-lint branch February 9, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant