Rewrite location config tests using tables #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good I was considering doing this once I saw what location configuration test was like in #842. |
Base automatically changed from
dev/issue-853-return-error-when-multiple-config
to
main
February 8, 2024 11:51
sevein
force-pushed
the
dev/issue-853-location-config-subtests
branch
from
5710411 to
cd3a5c6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #855 +/- ##
==========================================
+ Coverage 45.16% 45.26% +0.09%
==========================================
Files 93 93
Lines 5039 5039
==========================================
+ Hits 2276 2281 +5
+ Misses 2561 2555 -6
- Partials 202 203 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request rewrites the location config tests using tables and subtests. It does not introduce functional changes.
It depends on #854.