Fix issue with sending zipped bags to Archivematica #1133
Conversation
|
(Just noticed this isn't passing a test. I'll fix first.) |
mcantelon
force-pushed
the
dev/dir-upload-fix
branch
from
b38259d to
e5a5d36
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1133 +/- ##
==========================================
- Coverage 54.74% 54.72% -0.02%
==========================================
Files 105 105
Lines 7805 7806 +1
==========================================
- Hits 4273 4272 -1
- Misses 3264 3265 +1
- Partials 268 269 +1 ☔ View full report in Codecov by Sentry. |
|
(I've fixed the tests.) |
There was a problem hiding this comment.
I was testing main today and got an error in Archivematica's Job: Verify bag, and restructure for compliance, hopefully this fixes that issue.
Also, when setting the config value to false to see if that fixed the issue, I got another error in the DeleteTransferActivity:
2025-02-25T17:15:15.495Z V(2) enduro-am-worker.temporal-client log/with_logger.go:79 error {"Namespace": "default", "TaskQueue": "am", "WorkerID": "1@enduro-am-77978d78d9-qmprm@", "WorkflowID": "processing-workflow-df7ee783-2ce0-4e8d-87d0-b2a1bf610ca3", "RunID": "05dbbf27-c0f5-42bf-a8bf-854f3f6bf630", "ActivityType": "DeleteTransferActivity", "Attempt": 2, "Error": "delete transfer: path: \"bag-7537ab2c-4e6b-4820-95bf-bd2c577351c3\": SFTP: unable to remove file \"bag-7537ab2c-4e6b-4820-95bf-bd2c577351c3\": failure (SSH_FX_FAILURE)", "error": "Activity error."}
go.temporal.io/sdk/log.(*withLogger).Error
go.temporal.io/[email protected]/log/with_logger.go:79
go.temporal.io/sdk/internal.(*activityTaskHandlerImpl).Execute
go.temporal.io/[email protected]/internal/internal_task_handlers.go:2246
go.temporal.io/sdk/internal.(*activityTaskPoller).ProcessTask
go.temporal.io/[email protected]/internal/internal_task_pollers.go:1080
go.temporal.io/sdk/internal.(*baseWorker).processTaskAsync.func1
go.temporal.io/[email protected]/internal/internal_worker_base.go:446
They doesn't look to be related, but it would be nice to take a look if you have some time before release.
|
@jraddaoui Sounds good... I'll take a look! |
|
@jraddaoui "Verify Bag" and "Restructure for Complance" seem to work in Archivematica with this PR (either sending ZIPs or directoriees to AM). I'll look into the |
No description provided.