Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created time package list filter, refs #1102 #1116

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

djjuhasz
Copy link
Collaborator

@djjuhasz djjuhasz commented Feb 7, 2025

Add a package list dropdown filter to find packages created recently (in the last 3 hours to 7 days). I still need to do work to collapse the status tabs into a dropdown list, add the hidden filter panel, etc. to fully implement #1102, but I think this a good point to review the code and functionality.

@djjuhasz
Copy link
Collaborator Author

djjuhasz commented Feb 7, 2025

Here's a recording of current "Created" dropdown filter in action:
https://github.com/user-attachments/assets/a0f7ad34-d782-43ce-8932-5d9c5a76c453

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (be57611) to head (f39f74f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/package_/convert.go 83.33% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1116      +/-   ##
==========================================
- Coverage   54.73%   54.64%   -0.09%     
==========================================
  Files         105      105              
  Lines        7703     7713      +10     
==========================================
- Hits         4216     4215       -1     
- Misses       3228     3235       +7     
- Partials      259      263       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz force-pushed the dev/issue-1102-package-date-filter branch 7 times, most recently from 299fc84 to 03637f4 Compare February 11, 2025 22:03
Add a package list dropdown filter to find packages created recently
(in the last 3 hours to 7 days). I still need to do work to collapse
the status tabs into a dropdown list, add the hidden filter panel,
etc. to fully implement #1102, but I think this a good point to
review the code and functionality.
@djjuhasz djjuhasz force-pushed the dev/issue-1102-package-date-filter branch 3 times, most recently from cf96484 to f4f2324 Compare February 11, 2025 23:06
Add the ESLint import plugin to automatically sort Vue.js imports in
the Dashboard code.

After installing ESLint I ran `npx eslint --fix .` to auto-format files
where possible.
@djjuhasz djjuhasz force-pushed the dev/issue-1102-package-date-filter branch from f4f2324 to f39f74f Compare February 11, 2025 23:09
@djjuhasz djjuhasz requested a review from sevein February 11, 2025 23:30
Copy link
Contributor

@sevein sevein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've only tested the eslint config.

@djjuhasz djjuhasz merged commit 8322eba into main Feb 12, 2025
14 checks passed
@djjuhasz djjuhasz deleted the dev/issue-1102-package-date-filter branch February 12, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants