Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section in devel.md to submit transfer #1042

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

sevein
Copy link
Contributor

@sevein sevein commented Oct 14, 2024

As someone who only occasionally follows the instructions in https://enduro.readthedocs.io/dev-manual/devel/ since I don't work on this project daily, I often find myself trying to remember what was the easiest way to submit a new transfer. This pull request adds a small section to the instructions to clarify the process.

@sevein sevein requested review from djjuhasz and jraddaoui October 14, 2024 11:40
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.38%. Comparing base (f9bc127) to head (3d1733a).
Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1042      +/-   ##
==========================================
- Coverage   55.45%   55.38%   -0.07%     
==========================================
  Files         103      103              
  Lines        6021     6021              
==========================================
- Hits         3339     3335       -4     
- Misses       2431     2434       +3     
- Partials      251      252       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +215 to +217
Alternatively, run the following make thing to submit a transfer via the
`/package/upload` API via cURL:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make thing? 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't remember what was the actual name... goals, recipes, targets? And then I forgot to look it up :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules or targets, I think, not a big deal.

@jraddaoui jraddaoui force-pushed the dev/submit-transfer-section branch from 85f0e81 to 3d1733a Compare October 14, 2024 17:32
@jraddaoui jraddaoui merged commit 3d1733a into main Oct 14, 2024
12 of 13 checks passed
@jraddaoui jraddaoui deleted the dev/submit-transfer-section branch October 14, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants