-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send PIPs to Archivematica as BagIt bags #1007
Conversation
6985b40
to
0c97e80
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
+ Coverage 53.12% 53.15% +0.03%
==========================================
Files 102 102
Lines 5835 5856 +21
==========================================
+ Hits 3100 3113 +13
- Misses 2478 2484 +6
- Partials 257 259 +2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
0c97e80
to
f3de850
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djjuhasz, this looks great!
Some minor comments below and a bigger request after seeing the changes from both PRs (more related to #999 than to this one).
We decided at some point that preprocessing child workflows MUST return a valid Bag. If a preprocessing child workflow has been executed and the package is not identified as a Bag, we should fail the workflow instead of making it a Bag.
Check the following diagram that @sallain wrote a while ago, it doesn't include the identify activity but it tries to represent that, if a child workflow was run, we must have a valid Bag.
@jraddaoui okay, I've addressed your comments and the workflow will now stop if preprocessing returns a SIP that is not a bag. I also had to fight with prettier a bit about formatting markdown, and made some changes to the preprocessing_test script to get the preprocessing test working and for my sanity trying to figure out where preservation tasks are being created and completed. I'll squash all the changes before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @djjuhasz!
849f194
to
f249c48
Compare
Fixes #805 - Move the bundle activity to the a3m branch of the processing workflow - Change the package type to "zipped bag" when starting a transfer via the Archivematica API - Bag the PIP before sending it to Archivematica (if it's not already a bag) - Add a "TransferSourcePath" config value to specify the API path to the Transfer Source directory where PIPs are uploaded
After configuring prettier to use an indent of four spaces for Markdown files it is adding a four space indent after the "-" character in bulleted lists (see prettier/prettier#5019). For now configure prettier to ignore Markdown files altogether to avoid incorrect formatting changes.
f249c48
to
6471106
Compare
Fixes #805
the Archivematica API
bag)
Transfer Source directory where PIPs are uploaded