Add test for JHOVE module validation #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaceafill
reviewed
Feb 5, 2025
There was a problem hiding this comment.
@Dhwaniartefact Here's some initial feedback while I work on fixing the test workflow.
Dhwaniartefact
force-pushed
the
dev/issue-1723-test-jhove-validation
branch
from
8d02f26 to
f9d8f25
Compare
replaceafill
changed the title
Dhwaniartefact
force-pushed
the
dev/issue-1723-test-jhove-validation
branch
from
f9d8f25 to
827fba4
Compare
Dhwaniartefact
force-pushed
the
dev/issue-1723-test-jhove-validation
branch
4 times, most recently
from
e60a0c7 to
4a615d8
Compare
Dhwaniartefact
force-pushed
the
dev/issue-1723-test-jhove-validation
branch
from
4a615d8 to
ca2edc8
Compare
replaceafill
requested changes
Feb 19, 2025
There was a problem hiding this comment.
Great progress @Dhwaniartefact. I think I've spotted some potential problems and suggested some ways to address them.
This adds a amclient commit which introduces `detailed` parameter in the Jobs API endpoint
Dhwaniartefact
force-pushed
the
dev/issue-1723-test-jhove-validation
branch
from
05ea238 to
e4d4163
Compare
Dhwaniartefact
force-pushed
the
dev/issue-1723-test-jhove-validation
branch
from
8cc08c1 to
11efff9
Compare
Dhwaniartefact
requested review from
replaceafill
and removed request for
replaceafill
replaceafill
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Left a couple of suggestions, but after that this should be ready. Thank you @Dhwaniartefact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds acceptance test for JHOVE modules validation.
Connected to: archivematica/Issues#1723