Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure: Use wantlist on fpdict tasks #291

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

mamedin
Copy link
Contributor

@mamedin mamedin commented Mar 31, 2020

The loop keyword always requires a list, and it is known that in single item
lists that lookup will not return a list. Adding wantlist=True to the lookup
invocations allows to use dictionaries with a single item list.

Connects to #290

The loop keyword always requires a list, and it is known that in single item
lists that lookup will not return a list. Adding wantlist=True to the lookup
invocations allows to use dictionaries with a single item list.
@mamedin mamedin requested a review from scollazo March 31, 2020 10:18
@mamedin mamedin self-assigned this Mar 31, 2020
Copy link
Contributor

@scollazo scollazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mamedin mamedin merged commit 195fe0a into qa/1.x Mar 31, 2020
@mamedin mamedin deleted the dev/fpdicts_use_wantlist_with_lookup branch March 31, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants