Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motor get_database method additional kwargs support #71

Closed
wants to merge 3 commits into from
Closed

Motor get_database method additional kwargs support #71

wants to merge 3 commits into from

Conversation

Olegt0rr
Copy link
Contributor

Relates to #70

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #71 (914d494) into master (02a7ca7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          883       886    +3     
  Branches       143       143           
=========================================
+ Hits           883       886    +3     
Flag Coverage Δ
tests-3.6-4 99.08% <100.00%> (+<0.01%) ⬆️
tests-3.6-4.2 99.08% <100.00%> (+<0.01%) ⬆️
tests-3.6-4.4 99.08% <100.00%> (+<0.01%) ⬆️
tests-3.7-4 98.51% <100.00%> (+<0.01%) ⬆️
tests-3.7-4.2 98.51% <100.00%> (+<0.01%) ⬆️
tests-3.7-4.4 98.51% <100.00%> (+<0.01%) ⬆️
tests-3.8-4 98.30% <100.00%> (+<0.01%) ⬆️
tests-3.8-4.2 98.30% <100.00%> (+<0.01%) ⬆️
tests-3.8-4.4 98.30% <100.00%> (+<0.01%) ⬆️
tests-3.9-4 98.19% <100.00%> (+<0.01%) ⬆️
tests-3.9-4.2 98.19% <100.00%> (+<0.01%) ⬆️
tests-3.9-4.4 98.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
odmantic/engine.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a7ca7...914d494. Read the comment docs.

@Olegt0rr
Copy link
Contributor Author

Olegt0rr commented Dec 11, 2020

pymongo is a dependency of motor, but importing objects from pymongo make build / static-analysis (pull_request) failed
Seems it's a new issue for static-analysis stage

@art049
Copy link
Owner

art049 commented Dec 11, 2020

Since motor depends on it, you can add it to the known third party of isort (in the pyproject.toml). It will then be aware that this package should be considered like that.
Otherwise if you run isort locally, with task lint for example, it should add it automatically there.

@ivan-gj
Copy link

ivan-gj commented Jan 29, 2023

This should close #118

@art049 art049 force-pushed the master branch 2 times, most recently from 5bd1656 to a99a258 Compare November 3, 2023 20:39
@Olegt0rr Olegt0rr closed this by deleting the head repository Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants