Create index tables using the Twill table builder #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I started with the landing pages because it seemed straightforward with minimal columns. I found that we'll have to create a `setUpController` method and replace a few static variables with setters.
zachgarwood
force-pushed
the
feature/twill-index-tables
branch
from
ea895fd to
fd5e715
Compare
zachgarwood
force-pushed
the
feature/twill-index-tables
branch
from
798a523 to
567c8a5
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work replaces the
$indexColumnsarray in Twill controllers with agetIndexTableColumns()andsetUpController()methods that allow us to have more control over how the Twill admin displays the index table.