Fix tours API output [MA-156] #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachgarwood
requested changes
Feb 28, 2024
| @@ -10,7 +10,7 @@ class StopTransformer extends TransformerAbstract | |||
| public function transform(TwillModelContract $stop): array | |||
| { | |||
| return [ | |||
| 'object' => "$stop->object_type:$stop->object_id", | |||
| 'object' => class_basename($stop->selector?->object::class) . ':' . $stop->object_id, | |||
There was a problem hiding this comment.
You'll also need to update the ObjectTransformer, which currently lowercases the class name:
https://github.com/art-institute-of-chicago/aic-mobile-cms/blob/develop/app/Models/Transformers/ObjectTransformer.php#L21
There was a problem hiding this comment.
Ah, good to know. I'll update this PR to match what the ObjectTransformer is already doing.
| { | ||
| public function up(): void | ||
| { | ||
| LoanObject::query()->update(['is_on_view' => 1]); |
There was a problem hiding this comment.
I think we should also set the default for the is_on_view column to true:
$table->boolean('is_on_view')->default(true)->change();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.