Revert map_floors key for level LL [MA-157]

art-institute-of-chicago · Feb 21, 2024 · ef0f680 · ef0f680
1 parent 78e90b0
commit ef0f680
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/app/Models/Transformers/FloorTransformer.php b/app/Models/Transformers/FloorTransformer.php
@@ -11,8 +11,10 @@ class FloorTransformer extends TransformerAbstract
     public function transform(TwillModelContract $floor)
     {
         $floorPlan = $floor->fileObject('floor_plan');
+        // For backward compatibility, the key for level LL must be 'map_floor0'.
+        $mapFloor = $floor->level == 'LL' ? '0' : $floor->level;
         return [
-            "map_floor$floor->level" => [
+            "map_floor$mapFloor" => [
                 'label' => $floor->level,
                 'floor_plan' => $floorPlan ? secure_url('storage/uploads/' . $floorPlan?->uuid) : null,
                 'anchor_pixel_1' => Floor::ANCHOR_PIXELS[0],

diff --git a/tests/Feature/FloorSerializerTest.php b/tests/Feature/FloorSerializerTest.php
@@ -20,7 +20,15 @@ public function test_serialize(): void
         $this->assertArrayHasKey('map_floors', $serialized);
         foreach ($serialized['map_floors'] as $id => $floor) {
             $this->assertStringStartsWith('map_floor', $id);
-            $this->assertStringEndsWith($floor['label'], $id);
+            if ($floor['label'] == 'LL') {
+                $this->assertStringEndsWith(
+                    '0',
+                    $id,
+                    'For backward compatibility, the key for level LL must end in "0"'
+                );
+            } else {
+                $this->assertStringEndsWith($floor['label'], $id);
+            }
             $this->assertArrayHasKey('label', $floor);
             $this->assertArrayHasKey('floor_plan', $floor);
             $this->assertArrayHasKey('anchor_pixel_1', $floor);