download with filename #82
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
reviewed
Mar 25, 2022
| @@ -81,7 +82,8 @@ class Files { | |||
| if (opts.range) { | |||
| opts.headers.Range = `bytes=${opts.range.from || 0}-${opts.range.to || ''}` | |||
| } | |||
| return this.collection.fetch('/file/' + id, opts) | |||
| const query = opts.query || '' | |||
There was a problem hiding this comment.
the fetch function being used here (client/lib/fetch.js) already supports a params option with an object to set query string in the URL. So lets not add anothet way here. Instead add a doc comment that passing { params: { dl: 1 }} option will set the Content-Disposition header to attachement with the filename provided at upload, making the browser treat the file as a download (and not display in the browser).
|
Looks good! Added one comment, can be merged once that is addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
SONARURL/files/ID?dl=1for download stream with filenames