Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup release and update project build #76

Merged
merged 7 commits into from
Apr 4, 2022
Merged

Setup release and update project build #76

merged 7 commits into from
Apr 4, 2022

Conversation

i-walker
Copy link
Member

@i-walker i-walker commented Mar 29, 2022

resolves #70

  • transforms gradle groovy files to kts files
  • sets up release process based on tags, adds the alpha tag workflow and the release workflow
  • changes in the codebase are related to Spotless or explicitApi checks

@myuwono
Copy link
Collaborator

myuwono commented Mar 29, 2022

This is awesome! Thanks heaps @i-walker !! 🙌

@fredgalvao
Copy link

Before I create a new issue, just to make sure:

Does this PR (the upgrade and small fixes with it) address a test like this?

  @Test
  fun basicOptionParsing() {
    val mapper = ObjectMapper()
      .registerKotlinModule()
      .registerArrowModule()

    val optType = mapper.typeFactory.constructParametricType(
      Option::class.java,
      String::class.java
    )
    val nullToOption = mapper.readValue<Option<String>>("null", optType)
    println(nullToOption)
    Assertions.assertEquals(none<String>(), nullToOption, "null didn't parse to none()")

    val valueToOption = mapper.readValue<Option<String>>("\"value\"", optType)
    println(valueToOption)
    Assertions.assertEquals(Some("value"), valueToOption, "\"value\" didn't parse to some()")
  }

I recently found that the latest versions released of all related projects (see list below) cannot satisfy these expectations, and I'm guessing this PR will fix it.
Versions:

  • io.arrow-kt:arrow-core:1.0.6-alpha.1
  • io.arrow-kt:arrow-integrations-jackson-module:0.13.2
  • jackson-*:2.13.2

If I change jackson to 2.12.6, then it passes.
I'm also guessing this has to do with what is mentioned in the changelogs for Jackson 2.13:

Fix for databind#3271 to remove unintended coercion of JSON null into Java String "null" (in context of reading Type Id) had the downstream effect of breakage for DropWizard (reported as databind#3313).
New behavior is considered correct and will remain in 2.13 and later versions.

@i-walker i-walker merged commit 0e483d5 into main Apr 4, 2022
@i-walker i-walker deleted the setup-release branch April 4, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

["Request"] use arrow-gradle-config plugins and move to build.gradle.kts
3 participants