-
Notifications
You must be signed in to change notification settings - Fork 30
Provide Nullable alternatives to APIs that require Option #239
Provide Nullable alternatives to APIs that require Option #239
Conversation
Looks great so far to me 🙌 |
arrow-core-data/src/main/kotlin/arrow/typeclasses/TraverseFilter.kt
Outdated
Show resolved
Hide resolved
arrow-core-data/src/main/kotlin/arrow/typeclasses/FunctorFilter.kt
Outdated
Show resolved
Hide resolved
Looks like the meta annotation processor doesn't play well with nullable types:
the return type should be |
Thanks @LordRaydenMK !! Yes, please, create the issue and I'll take a look 👍 |
Looks like it's already there: #147 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much needed, thanks @LordRaydenMK !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of thoughts :) Great work 💪
arrow-core-data/src/main/kotlin/arrow/typeclasses/MonadFilter.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Pablo Gonzalez Alonso <[email protected]>
Co-authored-by: Pablo Gonzalez Alonso <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @LordRaydenMK! Thanks 👏 👏 🎉
Oh, I see, thanks @LordRaydenMK I thought it could be related with other dependencies that I updated recently. So it would be necessary to upgrade KotlinPoet to make it work. |
Oops, not sure what I did wrong in the merge 😅 I only fixed a doc with a conflict. |
I am happy to fix once #147 is resolved (as it is blocking merging this). |
@LordRaydenMK I'm not sure if you followed but we're in the process of removing Ref: #267 |
Hi fellow contributor 👋 Arrow repositories has been reunified again into Please, if you want to replay this pull request on
Please, let us know if we can help you! Thank you so much for your contributions!! 🙌 |
In order to move
Option
to a separate module first we need to remove all arrow-core-data and arrow-core usages from internal and public APIs and provide equivalent APIs with nullable types.Replaces internal
Option
usages with nullable types.Adds Nullable counterparts to Option APIs in typeclasses
Remove Option examples from API docs
Remove some deprecated methods with
Option
Note: I might have missed something, if that is the case I will do another PR.