Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Rework Fx constructors #185

Merged
merged 7 commits into from
Jul 23, 2020
Merged

Rework Fx constructors #185

merged 7 commits into from
Jul 23, 2020

Conversation

aballano
Copy link
Member

@aballano aballano commented Jul 9, 2020

Use an object to allow default suspend fx constructor and better discovery for eager one

Usage at the end is like the following:

import arrow.core.computations.either

fun non_suspend() {
  either.eager<Int, Int> { 1 } 
}

suspend fun suspend() {
  either<Int, Int> { 1 } 
}

(Re)fixes #133

@aballano aballano marked this pull request as ready for review July 20, 2020 11:39
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single shot computation blocks V1 landing in Arrow Core 🎉 🎉 🎉

@nomisRev
Copy link
Member

nomisRev commented Jul 23, 2020

@JorgeCastilloPrz @aballano merge is not longer blocked, correct?

Copy link
Member

@JorgeCastilloPrz JorgeCastilloPrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct @nomisRev feel free to merge anything you need to. I might need to give the course again pretty soon but until then we can keep moving.

@aballano aballano merged commit 7108393 into master Jul 23, 2020
@aballano aballano deleted the ab/rework-fx-constructors branch July 23, 2020 14:09
tapegram pushed a commit to tapegram/arrow-core that referenced this pull request Jul 23, 2020
* Use an object to allow default suspend fx constructor and better discovery for eager one

* Relocate fx constructors

Co-authored-by: Simon Vergauwen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a name for non-suspend fx block
3 participants