Skip to content
This repository has been archived by the owner on Feb 24, 2021. It is now read-only.

Suspend Const.fx implementation #160

Merged
merged 8 commits into from
Jun 19, 2020
Merged

Suspend Const.fx implementation #160

merged 8 commits into from
Jun 19, 2020

Conversation

aballano
Copy link
Member

@aballano aballano commented Jun 18, 2020 •
edited
Loading

Also changes all fx blocks to match their datatype as discussed in #133

Related to #116 #117

aballano added 4 commits June 18, 2020 15:13
@aballano
Add fx blocks to Const
8e645ed
@aballano
Adds Ior fx blocks
109897a
@aballano
Rename fx2 to fxEager for now
ed1aaba
@aballano
Revert "Adds Ior fx blocks"
e6df707 
This reverts commit 109897a.

# Conflicts:
#	arrow-core-data/src/test/kotlin/arrow/core/IorTest.kt
@aballano aballano requested review from nomisRev and pakoito June 18, 2020 14:53
@aballano aballano linked an issue Jun 18, 2020 that may be closed by this pull request
Figure out a name for non-suspend fx block #133
Closed
nomisRev
nomisRev approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@nomisRev nomisRev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @aballano! We should also deprecate the old fx blocks, but we can do that separately later.

cc\ @raulraja this also includes the refactor to top-level functions either, validated, eval & const. The other types still need a solution for flatMap.

@nomisRev nomisRev requested a review from raulraja June 18, 2020 15:45
@aballano
Copy link
Member Author

aballano commented Jun 18, 2020 •
edited
Loading

We should also deprecate the old fx blocks, but we can do that separately later.

Yes, it makes sense. I think I deleted them all, so next think I'll raise a PR bringing them back and deprecating them 👌

Do we also want to deprecate Monad.fx in the process? Yes we do :) #118 (comment)

@aballano aballano merged commit e63f342 into master Jun 19, 2020
@aballano aballano deleted the ab/final-fx-blocks branch June 19, 2020 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nomisRev nomisRev nomisRev approved these changes

@raulraja raulraja raulraja approved these changes

@pakoito pakoito Awaiting requested review from pakoito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out a name for non-suspend fx block
3 participants
@aballano @raulraja @nomisRev