updated function and added new tests

R/date_time_parsing.R

@@ -46,6 +46,11 @@ log_date_time_parse <- function(.data, .fun){
     new_na_count <- na_count_parsed - na_count_original
     success_index <- which(!is.na(parsed_dates))[1]
     failed_index <- which(!is.na(dates_char) & is.na(parsed_dates))[1]
+
+    if(new_na_count ){
+
+
+    }
     cli_alert_danger("NA values created by parsing: {new_na_count}")
 
     # Add successful parse example if exists

tests/testthat/test-dmy.R

@@ -1,14 +1,21 @@
 library(lubrilog)
+library(cli)
 
-
-cli::test_that_cli("danger",{
-  test_that("dmy works", {
-    expect_error(lubrilog::dmy(games$release_date))
-  })
-})
+data <- lubrilog::games
 
 
+f <- function(){
+  cli_alert_danger("NA values created by parsing:")
+  cli_alert_danger("Example failed parse:")
+  cli_alert("  Original: {dates_char[failed_index]}")
+  cli_alert("  Parsed:   NA")
+}
 
 test_that("dmy works", {
-  expect_error(lubrilog::dmy(games$release_date),NA)
+  expect_message(
+    out <- lubrilog::dmy(data$release_date)
+    )
+  expect_equal(length(out), nrow(data))
+
 })
+