address review comments

arrayfire · Aug 9, 2019 · 3c4184c · 3c4184c
1 parent 564180a
commit 3c4184c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 12 deletions.
diff --git a/include/fg/histogram.h b/include/fg/histogram.h
@@ -58,8 +58,8 @@ FGAPI fg_err fg_release_histogram(fg_histogram pHistogram);
    This is global alpha value for the histogram rendering that takes
    effect if individual bar alphas are not set by calling the following
    member functions
-       - Histogram::alphas()
-       - Histogram::alphasSize()
+       - fg_get_histogram_alpha_buffer
+       - fg_get_histogram_alpha_buffer_size
 
    \param[in] pHistogram is the histogram handle
    \param[in] pRed is Red component in range [0, 1]

diff --git a/include/fg/pie.h b/include/fg/pie.h
@@ -53,13 +53,13 @@ FGAPI fg_err fg_retain_pie(fg_pie *pOut, fg_pie pIn);
 FGAPI fg_err fg_release_pie(fg_pie pPie);
 
 /**
-   Set the color of bar in the bar graph(pie)
+   Set the color of all sectors in the pie chart
 
    This is global alpha value for the pie rendering that takes
-   effect if individual bar alphas are not set by calling the following
-   member functions
-       - Pie::alphas()
-       - Pie::alphasSize()
+   effect if individual sector alphas are not set in the buffer
+   obtained by the following functions
+      - fg_get_pie_alpha_buffer
+      - fg_get_pie_alpha_buffer_size
 
    \param[in] pPie is the pie handle
    \param[in] pRed is Red component in range [0, 1]
@@ -193,17 +193,17 @@ class Pie {
         FGAPI ~Pie();
 
         /**
-           Set the color of bar in the bar graph(pie)
+           Set the color of all sectors in the pie chart
 
-           \param[in] pColor takes values of type forge::Color to define bar color
+           \param[in] pColor takes values of type forge::Color to define sector color
         **/
         FGAPI void setColor(const Color pColor);
 
         /**
-           Set the color of bar in the bar graph(pie)
+           Set the color of all sectors in the pie chart
 
            This is global alpha value for the pie rendering that takes
-           effect if individual bar alphas are not set by calling the following
+           effect if individual sector alphas are not set by calling the following
            member functions
                - Pie::alphas()
                - Pie::alphasSize()

diff --git a/src/backend/opengl/pie_impl.hpp b/src/backend/opengl/pie_impl.hpp
@@ -14,7 +14,6 @@
 
 #include <glm/glm.hpp>
 
-#include <memory>
 #include <map>
 
 namespace forge