Use references while iterating when possible

arrayfire · Jul 6, 2017 · 8129b47 · 8129b47
1 parent 82d77dd
commit 8129b47
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/examples/perceptron.cpp b/examples/perceptron.cpp
@@ -61,7 +61,7 @@ int main()
 
             // Update parameters
             // TODO: Should use optimizer
-            for (auto param : perceptron.parameters()) {
+            for (auto &param : perceptron.parameters()) {
                 param.array() += lr * param.grad().array();
                 param.array().eval();
             }

diff --git a/include/af/autograd/Variable.hpp b/include/af/autograd/Variable.hpp
@@ -52,7 +52,7 @@ namespace af {
 
             af::array& array() const;
 
-            Variable grad() const;
+            Variable& grad() const;
 
             std::ptrdiff_t id() const;
 
@@ -74,7 +74,7 @@ namespace af {
         private:
             void evalGrad(bool retain_grad_graph = false);
 
-            std::vector<Variable> getInputs() const;
+            std::vector<Variable>& getInputs() const;
 
             static void buildSubGraph(Cache_t &cache, DAG_t &dag, const Variable &var);
 

diff --git a/src/autograd/Variable.cpp b/src/autograd/Variable.cpp
@@ -55,7 +55,7 @@ namespace af {
             m_shared(nullptr)
         {
             bool calc_grad = false;
-            for (auto input : inputs) {
+            for (const auto &input : inputs) {
                 calc_grad |= input.isCalcGrad();
             }
             if (calc_grad) {
@@ -70,7 +70,7 @@ namespace af {
             return m_shared->m_data;
         }
 
-        Variable Variable::grad() const
+        Variable& Variable::grad() const
         {
             if (!m_shared->m_calc_grad) {
                 throw af::exception("Gradient calclation disabled.");
@@ -86,7 +86,7 @@ namespace af {
             return (std::ptrdiff_t)m_shared.get();
         }
 
-        std::vector<Variable> Variable::getInputs() const
+        std::vector<Variable>& Variable::getInputs() const
         {
             return m_shared->m_inputs;
         }
@@ -181,7 +181,7 @@ namespace af {
             if (cache.find(id) != cache.end()) {
                 return;
             }
-            for (auto input : var.getInputs()) {
+            for (const auto &input : var.getInputs()) {
                 Variable::buildSubGraph(cache, dag, input);
             }
             cache[id] = true;

diff --git a/src/nn/Modules/Container.cpp b/src/nn/Modules/Container.cpp
@@ -33,7 +33,7 @@ namespace af
         Variable Sequential::forward(const Variable &input)
         {
             Variable output = input;
-            for(auto module : m_modules) {
+            for (auto &module : m_modules) {
                 output = module->forward(output);
             }
             return output;

diff --git a/src/nn/Modules/Module.cpp b/src/nn/Modules/Module.cpp
@@ -34,14 +34,14 @@ namespace af
 
         void Module::train()
         {
-            for (auto parameter : m_parameters) {
+            for (auto &parameter : m_parameters) {
                 parameter.setCalcGrad(true);
             }
         }
 
         void Module::eval()
         {
-            for (auto parameter : m_parameters) {
+            for (auto &parameter : m_parameters) {
                 parameter.setCalcGrad(false);
             }
         }