Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numeric Operations Testing #38

Merged
merged 5 commits into from
Mar 28, 2024
Merged

Conversation

AzeezIsh
Copy link
Contributor

This PR introduces a suite of unit tests for numeric_functions.py located within the within the mathematical functions directory. This PR also resolves issues from the numeric_functions.py file, specifically with functions like Hypotenuse -- hyp(), Negate -- neg(), and Clamp -- clamp().

Bug Resolution: Fixed pointer issues for both hypotenuse and clamp. For hypotenuse, it was missing a parameter feature, and also and out pointer. For clamp, the Boolean for batching was missing for the call_to_clib function. For negate, the only compatible array was of type f32, therefore I added a converter that grabbed the dtype of the inputted array and set that as the standard.

General Functionality: Tests confirm that the library accurately handles tests across various array shapes and dimensions, ensuring these operations perform correctly from scalars up to four-dimensional arrays. This encompasses verifying the maintenance of result dimensions in accordance with input shapes.

Data Type and Edge Case Handling: The library's robustness is tested against a comprehensive set of data types including integers, floating-points, and complex numbers (where applicable), affirming operation compatibility and precision. Additionally, scenarios involving shape mismatches, negative dimensions, and zero-sized arrays are explored, expecting runtime errors to prevent undefined behaviors.

AzeezIsh added 5 commits March 28, 2024 18:38
Fixed an error that only allowed for one dtype for negative class. Exploring how to resolve other runtime errors for hypotenuse and need to fill in all dtype testing for clamping func.
Was missing batch param, and out pointer, appended the same for clamp.
@syurkevi syurkevi merged commit 28e1c1b into arrayfire:master Mar 28, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants