Readability changes to constants tests #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umar456
reviewed
Mar 12, 2024
tests/test_constants.py
Outdated
|
|
||
| dtype = dtypes.c32 | ||
| dtype = c32 |
tests/test_constants.py
Outdated
| """Test if constant creates an array with the correct dtype.""" | ||
| if dtype_index in [1, 3] or (dtype_index == 2 and not wrapper.get_dbl_support()): | ||
| if dtype in [c32, c64] or (dtype == f64 and not wrapper.get_dbl_support()): |
There was a problem hiding this comment.
could be reused in other places. maybe rip it out and make it a function
umar456
approved these changes
Mar 13, 2024
|
Can you rebase please? |
sakchal
force-pushed
the
constants_tests
branch
from
527b807 to
bc96cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a suite of unit tests for the constants.py located within the within the create_array directory. The primary function in this file facilitate the creation of an array with specified dimensions and a constant value.
Dtype Parameterization: Made this parametrization more readable for viewers.