Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability for individual posts to set reading time #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add ability for individual posts to set reading time #28

wants to merge 3 commits into from

Conversation

ccjjmartin
Copy link

Purpose:

  • Add ability for individual posts to set reading time.

Description:

  • On posts with videos embedded I found it necessary to manually set the amount of reading time.

aron-bordin
aron-bordin reviewed Aug 1, 2016
View reviewed changes
_templates/post
@@ -5,10 +5,11 @@ modified:
categories: {{ dir }}
description:
tags: []
time: XX minutes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ccjjmartin, thanks for this PR. I'd prefer to have the time empty by default. Can you update this line for time:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ccjjmartin
Copy link
Author

@aron-bordin: I have updated the default time. I also noticed on individual pages the time wasn't updating. My second commit fixes that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccjjmartin @aron-bordin