Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add target field for cloud events #432

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

jnathangreeg
Copy link
Contributor

@jnathangreeg jnathangreeg commented Jan 23, 2025

PR Type

enhancement


Description

  • Added a new TargetResource field to the EventData struct.

  • Enhanced the EventData struct to include target resource information.


Changes walkthrough 📝

Relevant files
Enhancement
cdr.go
Add `TargetResource` field to `EventData` struct                 

armotypes/cdr/cdr.go

  • Added a new field TargetResource to the EventData struct.
  • Documented the purpose of the TargetResource field.
  • +2/-0     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @amitschendel amitschendel self-requested a review January 26, 2025 15:44
    @amitschendel amitschendel merged commit 93687f6 into main Jan 26, 2025
    3 checks passed
    @amitschendel amitschendel deleted the feature/cloud_event_target_parse branch January 26, 2025 15:45
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants