change IntegrationsConnectionStatus provider field to string

[refaelm92]

PR Type

enhancement

---

Description

• Changed the type of the Provider field in the IntegrationsConnectionStatus struct from ChannelProvider to string.
• This change likely simplifies the handling of provider information by using a basic data type.

---

Changes walkthrough 📝

	Relevant files
Enhancement	collaborationconfig.go Modify `Provider` field type to string in struct                  notifications/collaborationconfig.go Changed the Provider field type from ChannelProvider to string in IntegrationsConnectionStatus. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[codiumai-pr-agent-free]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Type Validation Changing from ChannelProvider enum to string removes type safety. Need to verify that all code using this field properly validates the provider string values.

[codiumai-pr-agent-free]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Implement string validation to maintain type safety when converting from an enum to a string field Consider validating the string value of Provider to ensure it matches expected provider types, since changing from ChannelProvider enum to string removes type safety. notifications/collaborationconfig.go [90-93] type IntegrationsConnectionStatus struct { - Provider string `json:"provider"` + Provider ProviderType `json:"provider"` Status IntegrationConnectionStatus `json:"status"` } +type ProviderType string + +func (p ProviderType) Validate() error { + validTypes := []ProviderType{"slack", "teams", "email"} // add your valid types + for _, t := range validTypes { + if p == t { + return nil + } + } + return fmt.Errorf("invalid provider type: %s", p) +} + Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion addresses a significant potential issue where changing from a strongly-typed enum (ChannelProvider) to a string removes type safety, which could lead to runtime errors. The proposed solution of adding validation maintains data integrity while providing clear error messaging.	8

💡 Need additional feedback ? start a PR chat