Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minnaker): Support Docker Desktop (Docker for Mac) #25

Merged
merged 7 commits into from
Jan 15, 2020
Merged

Conversation

justinrlee
Copy link
Contributor

No description provided.

@armory-jenkins
Copy link

The title of the Pull Request needs to be changed.
Please follow https://www.spinnaker.io/community/contributing/submitting/#commit-message-conventions

@justinrlee justinrlee changed the title Minnaker for Docker for Mac (Docker Desktop) feat(minnaker): Support Docker Desktop (Docker for Mac) Dec 5, 2019
Copy link
Contributor

@robzienert robzienert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I'll kick the tires on this during quiet period 🤞

@robzienert
Copy link
Contributor

It works! Thanks man!

@robzienert
Copy link
Contributor

However, it would be nice to be able to define what port Minnaker will listen on.

@justinrlee justinrlee merged commit 4ef9d1c into master Jan 15, 2020
@justinrlee
Copy link
Contributor Author

Created issue #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants