Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a github action #118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a github action #118

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link

This verifies that tests pass on master and in PRs.

@eric-wieser
Copy link
Author

(you can see proof this works at https://github.com/eric-wieser/cadical/tree/ci; the actual CI won't run here unless you merge the PR)

@arminbiere
Copy link
Owner

arminbiere commented Oct 31, 2024

Thanks, but, at this point we have no plans to do CI on github.

@eric-wieser
Copy link
Author

How about CI on GitHub? (Perhaps you have a private gitlab copy I can't see somewhere)

Note that no real plan is needed; merging these 22 lines of config will be sufficient to enable CI; and it it gets in the way somehow, it can be disabled by deleting this file again.

@arminbiere
Copy link
Owner

Typo: meant 'github' not 'gitlab' (fixed).

I just do not want to generate any expectations here. That is why I prefer not to have any hint at providing CI support in the main branch.

Our main concern is actually not CI in terms of compilation and running unit tests but performance regressions, which for such solvers is not only a major headache in industrial use but also expensive to test (we are talking about thousands of CPU hours per test) and even much worse to debug (our next release will remove some of them). This can not be done with a CI anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants