Fix preemption reason - fairshare preemption (#4045)

We were incorrectly resetting the PreemptingJobId, which shouldn't get reset The UnschedulableReason is only reset as we try scheduling the jobs several times, during these rounds the jobs we're scheduling cannot be preempted - so it makes no sense to reset their PreemptingJobId This makes it so we now correct populate the preemption reason for fairshare preemption Signed-off-by: JamesMurkin <[email protected]>
armadaproject · Nov 15, 2024 · b3b07b9 · b3b07b9
1 parent 43d53a5
commit b3b07b9
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/internal/scheduler/nodedb/nodedb.go b/internal/scheduler/nodedb/nodedb.go
@@ -340,7 +340,6 @@ func (nodeDb *NodeDb) ScheduleManyWithTxn(txn *memdb.Txn, gctx *context.GangSche
 		// order to find the best fit for this gang); clear out any remnants of
 		// previous attempts.
 		jctx.UnschedulableReason = ""
-		jctx.PreemptingJobId = ""
 
 		node, err := nodeDb.SelectNodeForJobWithTxn(txn, jctx)
 		if err != nil {