Skip to content

Commit

Permalink
Fixing bug in _proto_methods.py (#3659)
Browse files Browse the repository at this point in the history
* Fixing bug in _proto_methods.py

`is_active` and `is_terminal` are intended to be methods on the JobState object.

* Bump Python client version

* Update _proto_methods.py
  • Loading branch information
MustafaI authored Jun 10, 2024
1 parent 2e11876 commit a8a64e4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions client/python/armada_client/_proto_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def is_terminal(self) -> bool:
JobState.CANCELLED,
JobState.PREEMPTED,
}
return self.value in terminal_states
return self in terminal_states


def is_active(self) -> bool:
Expand All @@ -35,4 +35,4 @@ def is_active(self) -> bool:
:returns: True if the job state is active, False if it is terminal.
:rtype: bool
"""
return not is_terminal(self.value)
return not is_terminal(self)
2 changes: 1 addition & 1 deletion client/python/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "armada_client"
version = "0.3.3"
version = "0.3.4"
description = "Armada gRPC API python client"
readme = "README.md"
requires-python = ">=3.7"
Expand Down

0 comments on commit a8a64e4

Please sign in to comment.