Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace derivative with educe #146

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

weikengchen
Copy link
Member

@weikengchen weikengchen commented Jul 17, 2024

Description

Same as a related PR in algebra: arkworks-rs/algebra#832

There are some side effects of the derivative crate due to it being in a very old Rust edition. This PR replaces derivative with a popular alternative, educe.

It also appears that educe simplifies some derivations.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Re-reviewed Files changed in the Github PR explorer

N/A:

  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md

@weikengchen weikengchen requested a review from a team as a code owner July 17, 2024 16:41
@weikengchen weikengchen requested review from z-tech, Pratyush and mmagician and removed request for a team July 17, 2024 16:41
@weikengchen
Copy link
Member Author

Let me take a look at the failing test---I think Rust changes how it handles "cfg(ci)".

@weikengchen
Copy link
Member Author

Added the lint exception to let Rust allow "ci" cfg, and then, patch the std as well, which is necessary in loading alloc::sync when std::sync is not present.

@weikengchen weikengchen merged commit 4fb0adf into arkworks-rs:master Jul 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants