Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visibility of get_limbs_representations #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

skaunov
Copy link

@skaunov skaunov commented Feb 8, 2024

(Also additional tiny style fix.)

(Also additional tiny style fix.)
@skaunov skaunov requested a review from a team as a code owner February 8, 2024 01:55
@skaunov skaunov requested review from z-tech, mmagician and weikengchen and removed request for a team February 8, 2024 01:55
/// functions
pub fn get_limbs_representations(
/// functions.
pub(super) fn get_limbs_representations(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to leave this public, as possibly downstream code might need to use it. Maybe we can mark it as #[doc(hidden)] instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have code that uses it, don't see why it has to be hidden even.

@skaunov
Copy link
Author

skaunov commented Feb 8, 2024 via email

@Pratyush
Copy link
Member

Pratyush commented Feb 9, 2024

Sure, let's keep it pub and change the doc. @skaunov if you want to update the PR to do that, that would be great

@skaunov
Copy link
Author

skaunov commented Feb 9, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants