Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Mul<NonNativeFieldVar> for Group #134

Merged
merged 14 commits into from
Dec 28, 2023
Merged

Add Mul<NonNativeFieldVar> for Group #134

merged 14 commits into from
Dec 28, 2023

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Dec 26, 2023 •
edited
Loading

Description

closes: #132

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush Pratyush requested a review from a team as a code owner December 26, 2023 03:43
@Pratyush Pratyush requested review from z-tech, mmagician and weikengchen and removed request for a team December 26, 2023 03:43
@Pratyush Pratyush changed the title Add mul by non-native field var Add Mul<NonNativeFieldVar> for Group Dec 28, 2023
@Pratyush Pratyush merged commit 1ff3a90 into master Dec 28, 2023
5 of 11 checks passed
@Pratyush Pratyush deleted the mul-by-nonnative branch December 28, 2023 03:07
@Pratyush Pratyush mentioned this pull request Dec 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

@weikengchen weikengchen Awaiting requested review from weikengchen weikengchen is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mul<NonNativeFieldVar<G::ScalarField, G::BaseField>> to G: Group
1 participant
@Pratyush