Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(src): typo fix #131

Closed
wants to merge 3 commits into from
Closed

Conversation

sqltrigger
Copy link

Hi I fixed a few typo in ./src. Those are comments typos so really minor changes. Have a nice evening.

@sqltrigger sqltrigger requested a review from a team as a code owner December 13, 2023 21:41
@sqltrigger sqltrigger requested review from z-tech, mmagician and weikengchen and removed request for a team December 13, 2023 21:41
@mmagician
Copy link
Member

Similar: arkworks-rs/curves#185 (comment)

@mmagician mmagician closed this Dec 14, 2023
@weikengchen
Copy link
Member

weikengchen commented Dec 15, 2023

At this moment, we have to blank-reject any GitHub submission from accounts whose profile is private. This could likely last for a while.

Please do not try to game the current system. As an investor myself, our industry has started to significantly restrict airdrops only to individuals that provide significant value adds. If more people are gaming this system, the result is that investors and startups will just restrict the airdrop reward even further, making the airdrop system fully centralized. This is not what you want to see.

@sqltrigger
Copy link
Author

sqltrigger commented Dec 17, 2023

At this moment, we have to blank-reject any GitHub submission from accounts whose profile is private. This could likely last for a while.

Please do not try to game the current system. As an investor myself, our industry has started to significantly restrict airdrops only to individuals that provide significant value adds. If more people are gaming this system, the result is that investors and startups will just restrict the airdrop reward even further, making the airdrop system fully centralized. This is not what you want to see.

To avoid fictionnal airdrop system centralization (no arkworks-rs airdrop, so it's pure speculation), you're centralizing the github and the way of contributing to the project, that's quite hypocritical.

My profile is private because it's linked to my real job and I wish not to be doxxed.

Those changes certainly aren't major, I get but we're far from the bot attack you seem to describe. There's only been one typo PR in the whole history of this repo.

Also, there's no automatic script for this, the errors all are handchecked. I can work on codepell workflow implementation if wished.

Have a nice sunday.

@weikengchen
Copy link
Member

This has started to appear in a large number of repositories across different companies. If this is not your intention, then I apologize, but this is not the only one.

@weikengchen
Copy link
Member

Can you explain why you typo-fix a large number of ZK repos?

@weikengchen
Copy link
Member

And I recommend you not to follow up with me in this thread and avoid further activity related to arkworks.

You have submitted PRs on typos in many different repos. Continuing engaging with me is going to waste your existing efforts and typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants