Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ark-relations/std dependency #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mzabaluev
Copy link

@mzabaluev mzabaluev commented Jul 26, 2024

Description

The std feature in ark-relations pulls in the hefty, and currently outdated (arkworks-rs/snark#356), dependency on tracing-subscriber. Luckily, this dependency does not seem to be needed here at all.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

The std feature in ark-relations pulls in the hefty, and currently
outdated, dependency on tracing-subscriber. Luckily, this dependency
does not seem to be needed here at all.
@mzabaluev mzabaluev requested a review from a team as a code owner July 26, 2024 17:04
@mzabaluev mzabaluev requested review from z-tech, mmagician and weikengchen and removed request for a team July 26, 2024 17:04
@weikengchen
Copy link
Member

Can you confirm if this change would work? The reason is that ark-crypto-primitives/std also will invoke ark-relations/std.

@mzabaluev
Copy link
Author

mzabaluev commented Jul 28, 2024

Can you confirm if this change would work? The reason is that ark-crypto-primitives/std also will invoke ark-relations/std.

I have submitted arkworks-rs/crypto-primitives#146 to remove that dependency as well.
However, it is still pulled in by r1cs-std/std, so I have submitted arkworks-rs/r1cs-std#147.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants