This repository has been archived by the owner on Dec 18, 2023. It is now read-only.
feat: Add support for constraint usage within ark_bn254 #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modifies the `Cargo.toml` with the following changes: - Add `ark-r1cs-std` as an optional dependency. - Add `ark-curve-constraint-tests` an a dev-dependency. - Add `r1cs` feature which activates `ark-r1cs-std` depencendy. (cherry picked from commit 4868735)
Resolves: #186
|
Fixing the tests issues. Did not run |
|
Sorry for the trouble, but could you make this PR against the curves folder in arkworks-rs/algebra? We've migrated our specific curve implementations there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This modifies the
Cargo.tomlwith the following changes:ark-r1cs-stdas an optional dependency.ark-curve-constraint-testsan a dev-dependency.r1csfeature which activatesark-r1cs-stddepencendy.It also adds all the necessary module files witin the
constraintsfolder to make it work in 8cb2eaecloses: arkworks-rs/algebra#719
cc: @arnaucube