Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mul mle by scalar #845

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Mul mle by scalar #845

merged 3 commits into from
Jul 4, 2024

Conversation

ssolit
Copy link
Contributor

@ssolit ssolit commented Jun 27, 2024

Description

Implements Mul for DenseMultilinearExtension and similar Mul Functions.

Currently to multiply a DenseMultilinearExtension by a Scalar, one has to iterate over the evaluations field and manually create a new object. Implementing the Mul and MulAssign functions for DenseMultilinearExtension * F will simplify the code for this very fundamental and common operation.

closes: #844

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@ssolit ssolit requested review from a team as code owners June 27, 2024 20:41
@ssolit ssolit requested review from z-tech, Pratyush and mmagician and removed request for a team June 27, 2024 20:41
@Pratyush Pratyush added this pull request to the merge queue Jul 4, 2024
Merged via the queue into arkworks-rs:master with commit e6374ba Jul 4, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pratyush Pratyush Pratyush approved these changes

@z-tech z-tech Awaiting requested review from z-tech z-tech is a code owner automatically assigned from arkworks-rs/maintainers

@mmagician mmagician Awaiting requested review from mmagician mmagician is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Mul for DenseMultilinearExtension * Scalar
2 participants
@ssolit @Pratyush