docs: website margin improvements #821
Conversation
|
@malezjaa Hey thanks so much for submitting these changes- I know we didn't do much mobile testing for layout, and it's good to know about some of these issues. When I tested the changes out on my 1920x1080 monitor, things looked a little off. I'd prefer to maintain the original alignments/sizes of some of these items that appear to have changed. Would you be able to test out your changes on a 1080p screen and make sure the overall appearance of the website doesn't change in these areas compared to the live https://arktype.io site? ###Original (changes circled): ###Updated: I also noticed the background of some of the code demos changed and looks a little off to me now. Not sure if again it just has something to do with the screen: ###Original: ###Updated: In general, if there are a few margins you can adjust that still look good on a desktop and fix the display on mobile, that's great and it would be awesome if you could submit those! There are a lot of other tweaks here though, the purpose of which isn't totally clear, so if you want to make other changes maybe you can individually explain them ideally with images of where it looks problematic, that'd be really helpful so I can better understand! |
|
Sorry about that 😄 I think I have fixed it. |
|
Awesome, this looks much better! The only thing left is just some of the proportions around the installation block, which I notice is quite a bit larger, filling up the entire space of the header. Is there any way to solve the issue you're having on mobile while still preserving the margins that were originally defined or something close to them? Original: Updated: I definitely prefer the condensed look for this widget. |
|
|
|
Thank you for your time. 🙏 |
@malezjaa I can live with that! Merged⛵ Thank you for your help and congrats on your first ArkType PR!🎊
Hi I found some bugs on the site so I fixed that.
Changes