Skip to content

Commit

Permalink
register for v1beta1 gateway api
Browse files Browse the repository at this point in the history
* `ReferenceGrant` is still on v1beta1

Fixes: envoyproxy#2005

Signed-off-by: Arko Dasgupta <[email protected]>
  • Loading branch information
arkodg committed Oct 19, 2023
1 parent d3110e3 commit 4833cf5
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 3 deletions.
4 changes: 4 additions & 0 deletions internal/envoygateway/scheme.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
clientgoscheme "k8s.io/client-go/kubernetes/scheme"
gwapiv1 "sigs.k8s.io/gateway-api/apis/v1"
gwapiv1a2 "sigs.k8s.io/gateway-api/apis/v1alpha2"
gwapiv1b1 "sigs.k8s.io/gateway-api/apis/v1beta1"
mcsapi "sigs.k8s.io/mcs-api/pkg/apis/v1alpha1"

egv1a1 "github.com/envoyproxy/gateway/api/v1alpha1"
Expand Down Expand Up @@ -37,6 +38,9 @@ func init() {
if err := gwapiv1.AddToScheme(scheme); err != nil {
panic(err)
}
if err := gwapiv1b1.AddToScheme(scheme); err != nil {
panic(err)
}
if err := gwapiv1a2.AddToScheme(scheme); err != nil {
panic(err)
}
Expand Down
2 changes: 1 addition & 1 deletion site/content/en/latest/user/secure-gateways.md
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ namespace to reference Secrets in the "envoy-gateway-system" namespace:

```console
$ cat <<EOF | kubectl apply -f -
apiVersion: gateway.networking.k8s.io/v1alpha2
apiVersion: gateway.networking.k8s.io/v1beta1
kind: ReferenceGrant
metadata:
name: example
Expand Down
1 change: 0 additions & 1 deletion test/conformance/conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ func TestGatewayAPIConformance(t *testing.T) {
SupportedFeatures: suite.AllFeatures,
SkipTests: []string{
tests.GatewaySecretInvalidReferenceGrant.ShortName,
tests.HTTPRouteReferenceGrant.ShortName,
tests.HTTPRouteRewritePath.ShortName,
tests.GatewayStaticAddresses.ShortName,
},
Expand Down
1 change: 0 additions & 1 deletion test/conformance/experimental_conformance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ func experimentalConformance(t *testing.T) {
CleanupBaseResources: *flags.CleanupBaseResources,
SkipTests: []string{
tests.GatewaySecretInvalidReferenceGrant.ShortName,
tests.HTTPRouteReferenceGrant.ShortName,
tests.HTTPRouteRewritePath.ShortName,
tests.GatewayStaticAddresses.ShortName,
},
Expand Down

0 comments on commit 4833cf5

Please sign in to comment.