add "block" scheduler type + sweep integration test #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds necessary changes to encode round lifetime in number of blocks. It allows writing an integration test for the sweeper.
TL;DR
bip68.go: usebtcdfunctions instead of custom ones ; remove test file (duplicate of btcd unit tests).ARK_ROUND_LIFETIMEsmaller than 512 now works ifARK_SCHEDULER_TYPEis set to "block". In that case, the lifetime is encoded in terms of block height instead of seconds.TestSweepin covenant & covenantlessdisclaimer
block scheduler type has the disadvantage to rely on esplora API whereas gocron scheduler does not call any endpoints. Always prefer gocron in production._
@altafan please review