fix: "tree signing session not found" error #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altafan
reviewed
Sep 18, 2024
tiero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains hotfixes regarding the tree signing session during claim. It adds a test to reproduce the error. It also includes a fix in btc-embedded coinselection (unrelated to the original error but raised by the test)
Claim failing error
The problem is coming from
handleRoundStreamSDK function receiving "RoundFinalized" event not related to the current round, making the SDK to register two times the same payment, causing the timeout error server side.fix = ignore unrelated round finalized event client side + check for duplicate inputs while registering payments.
Coin selection fixes
it closes #308
@altafan @bordalix please review